[
https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272203#comment-13272203
]
[email protected] commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-10 09:09:35.854462)
Review request for oozie.
Changes
-------
Fixed 2 bugs in coord change:
1. checkEndTime() was not using coord timeunit to compute actual last action
time
2. if coord change sets end time > actual last action time, but end time <
coord last action time, then doneMaterialization is never called and coord
state remains in RUNNING state forever
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while
calculating the action times. So, if the frequency is non-minutes(hours, days,
months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
1335944
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
1335944
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
1335944
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
1335944
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
> while calculating the action times. So, if the frequency is
> non-minutes(hours, days, months...), setting pause time can delete past coord
> actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
