[
https://issues.apache.org/jira/browse/OOZIE-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278269#comment-13278269
]
[email protected] commented on OOZIE-821:
-----------------------------------------------------
bq. On 2012-05-15 18:28:20, Virag Kothari wrote:
bq. > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java,
line 214
bq. > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line214>
bq. >
bq. > can we have a function foo(File, String) which will write the string
to the file? this will increase readability
bq. >
yes, since it is done similarly at more than one place
bq. On 2012-05-15 18:28:20, Virag Kothari wrote:
bq. > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java,
line 224
bq. > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line224>
bq. >
bq. > is this required if the next call is close()?
right it is not. taking it out
bq. On 2012-05-15 18:28:20, Virag Kothari wrote:
bq. > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java,
line 219
bq. > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line219>
bq. >
bq. > can this just have only necessary info like 'debug', '_L19_' instead
of a big string?..same comment for other places
the XLogStreamer filter is defined in the beginning with parameters that keep
it coherent-looking with the oozie log format. Hence I'm adding the big string
to pass that filter.
bq. On 2012-05-15 18:28:20, Virag Kothari wrote:
bq. > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java,
line 271
bq. > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line271>
bq. >
bq. > did u mean 2012-03-24
No, instead the parameter passed should be 2012, 4, 23. Fixing the date values
in the log lines too
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4881/#review7902
-----------------------------------------------------------
On 2012-04-26 00:15:30, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4881/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 00:15:30)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie.log files can be gzipped by a log setting and then we work with
hourly .gz log files. For a long running job spanning multiple hours, OOZIE-590
fixed the log retrieval issue from multiple such gz files. I'm adding a unit
test for checking this functionality.
bq.
bq.
bq. This addresses bug OOZIE-821.
bq. https://issues.apache.org/jira/browse/OOZIE-821
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
1326832
bq.
bq. Diff: https://reviews.apache.org/r/4881/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Unit test to account for log retrieval from multiple gzipped oozie.log files
> ----------------------------------------------------------------------------
>
> Key: OOZIE-821
> URL: https://issues.apache.org/jira/browse/OOZIE-821
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Priority: Minor
> Labels: oozie
> Fix For: 3.2.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Oozie.log files can be gzipped by a log setting and then we work with hourly
> gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed
> the log retrieval issue from multiple such gz files. I'm adding a unit test
> for checking this functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
