[
https://issues.apache.org/jira/browse/OOZIE-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278335#comment-13278335
]
[email protected] commented on OOZIE-821:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4881/#review7966
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17306>
USER[oozie] GROUP[-] TOKEN[-] APP[example-"
+ "forkjoinwf] " + "JOB[14-200904160239--example-forkjoinwf] ACTION[-] End
workflow state change"
This string is repeated 4-5 times here and in the previous function. Can we
put it into a variable?. That would make the function look cleaner.
Other than that, looks good
- Virag
On 2012-05-17 22:06:05, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4881/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-17 22:06:05)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie.log files can be gzipped by a log setting and then we work with
hourly .gz log files. For a long running job spanning multiple hours, OOZIE-590
fixed the log retrieval issue from multiple such gz files. I'm adding a unit
test for checking this functionality.
bq.
bq.
bq. This addresses bug OOZIE-821.
bq. https://issues.apache.org/jira/browse/OOZIE-821
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
1338503
bq.
bq. Diff: https://reviews.apache.org/r/4881/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Unit test to account for log retrieval from multiple gzipped oozie.log files
> ----------------------------------------------------------------------------
>
> Key: OOZIE-821
> URL: https://issues.apache.org/jira/browse/OOZIE-821
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Priority: Minor
> Labels: oozie
> Fix For: 3.2.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Oozie.log files can be gzipped by a log setting and then we work with hourly
> gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed
> the log retrieval issue from multiple such gz files. I'm adding a unit test
> for checking this functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
