----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6512/#review10174 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java <https://reviews.apache.org/r/6512/#comment21533> This seems to be opposite of what is intended. All the entries from the iterator should be added to the list and bulkdeletejpa should be called with this list outside the loop trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java <https://reviews.apache.org/r/6512/#comment21534> there should be a bulk delete for bundle actions too trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java <https://reviews.apache.org/r/6512/#comment21535> false change related to import..seems throughout the patch trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/6512/#comment21536> the update would never execute as the function would return in the next line trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/6512/#comment21537> SLAdb also does a write and should be accounted for in the bulk updates trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java <https://reviews.apache.org/r/6512/#comment21538> the update wont execute as function returns before jpa update is called. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java <https://reviews.apache.org/r/6512/#comment21539> This command can only do one write operation. So doing a bulk operation is not necessary. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java <https://reviews.apache.org/r/6512/#comment21540> This updates are not meant to be done in finally. They should be done here. Also, its ok for these updates to be not done in bulk as the error case is being handled in the finally block trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java <https://reviews.apache.org/r/6512/#comment21541> the sladb write should be done through bulk trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java <https://reviews.apache.org/r/6512/#comment21542> jpa update should be done here trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java <https://reviews.apache.org/r/6512/#comment21543> sladb write should be done through bulk update trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/6512/#comment21544> does this do sla writes too? trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java <https://reviews.apache.org/r/6512/#comment21545> same comment as for bundle purge trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java <https://reviews.apache.org/r/6512/#comment21546> same comment as for coord actions delete trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/6512/#comment21547> sla writes? trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java <https://reviews.apache.org/r/6512/#comment21548> the code should remain unchanged here. The bulk jpa would never be called if the control is in finally block trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/6512/#comment21549> seems only a single insert is done by this command. If that is true, no need for bulk writes. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java <https://reviews.apache.org/r/6512/#comment21550> same comment as before which is related to 'finally' trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java <https://reviews.apache.org/r/6512/#comment21551> wont work as function return nulls immediately. - Virag Kothari On Aug. 10, 2012, 6:08 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6512/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2012, 6:08 p.m.) > > > Review request for oozie. > > > Description > ------- > > Refer to JIRA OOZIE-914 > > > This addresses bug OOZIE-914. > https://issues.apache.org/jira/browse/OOZIE-914 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1370869 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateDeleteForRerunJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateForCoordActionInputCheckJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateForCoordActionStartJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateForCoordActionStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionUpdateJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsDeleteForPurgeJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobUpdateJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteForPurgeJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobUpdateJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionUpdateJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsDeleteForPurgeJPAExecutor.java > 1370869 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobUpdateJPAExecutor.java > 1370869 > > Diff: https://reviews.apache.org/r/6512/diff/ > > > Testing > ------- > > Unit tests to follow > > > Thanks, > > Mona Chitnis > >
