----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6512/#review10532 -----------------------------------------------------------
patch looks good...+1 after inserting javadoc at couple of places and removing jpa writes from finally for some commands as discussed.. plz attach the patch after making changes to jira and also here... trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateDeleteJPAExecutor.java <https://reviews.apache.org/r/6512/#comment22539> javadoc..same for other new test classes - Virag Kothari On Aug. 17, 2012, 3:06 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6512/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 3:06 a.m.) > > > Review request for oozie. > > > Description > ------- > > Refer to JIRA OOZIE-914 > > > This addresses bug OOZIE-914. > https://issues.apache.org/jira/browse/OOZIE-914 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertForCoordActionStartJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertForCoordActionStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsDeleteForPurgeJPAExecutor.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobDeleteJPAExecutor.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteForPurgeJPAExecutor.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java > 1374100 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsDeleteForPurgeJPAExecutor.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1374100 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1374100 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 1374100 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java > 1374100 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStartJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java > 1374100 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java > 1374100 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java > 1374100 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java > 1374100 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java > 1374100 > > trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java > 1374100 > > Diff: https://reviews.apache.org/r/6512/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Mona Chitnis > >
