Mark Marshall wrote: > I haven't yet learnt latex. I like lyx. I don't know how it deals with hand made latex, but it's a nice tool.
> The only other thing I've changed is that there used to be lines like: > > wire mem_space_i = cbe_d[3:1] == 'b011 || > cbe_d == 'b1100 || > cbe_d[3:1] == 'b111; > > Which I have chnaged to this: > > wire mem_space_i = (cbe_d == PCI_COMMAND_MEM_READ || > cbe_d == PCI_COMMAND_MEM_WRITE || > cbe_d == PCI_COMMAND_MEM_READ_N || > cbe_d == PCI_COMMAND_MEM_READ_LINE || > cbe_d == PCI_COMMAND_MEM_WRITE_INV); > > As far as I can tell the tools produce the same output, and the second is > much easier to understand. If there really is a good technical reason for > having lines like the first then I'll change them back, but I couldn't see > any. The first logic ignores bit 0 for commands 011 and 111. If you list those commands explicitly instead then that is of course logically equivalent and I would expect synthesizers to optimize it into the exact same RTL either way. Agree your change makes it more readable. > Peter Stuge's git mirror is very useful for looking at these > changes, if you don't have the source installed yourself. > > http://git.stuge.se/?p=ogp.git;a=summary;js=1 Great if it helps anyone! It's also possible to download a tarball or zip with any commit. For viewing a change I recommend the commitdiff view, which shows both the commit message and the patch directly in the browser. If there's interest I'd be happy to add a map of svn usernames to fullname+email to make the history more obvious. Also, if this becomes popular, it might make sense to approach the norm for git commit messages with a first line with short summary, a blank line 2, and finally as many further lines as needed with a longer description of the commit, but keeping line length around 70. It's not at all a requirement, it just looks nice in gitweb. :) //Peter _______________________________________________ Open-graphics mailing list [email protected] http://lists.duskglow.com/mailman/listinfo/open-graphics List service provided by Duskglow Consulting, LLC (www.duskglow.com)
