Hi Jane, I've added few comments about unit tests to the doc. Instead of specifying yes/no for unit tests, I've opted to note that shared services and components are highest priority targets for unit tests.
-b On Fri, Jan 18, 2019 at 2:36 PM Jane Sandberg <sand...@linnbenton.edu> wrote: > Thanks for doing this, Bill! I'd be interested in some guidance on > when Angular unit tests are necessary, and any best practices for > writing Angular tests and keeping non-test Angular code test-able. > > -Jane > > On Fri, Jan 18, 2019 at 9:02 AM > <open-ils-dev-requ...@list.georgialibraries.org> wrote: > > > > Hi All, > > > > I started compiling a list of things I try to do when developing Angular > UI > > code. I'm hoping we can extend, edit, polish, etc. into an agreed upon > set > > of practices for developers working on the Angular code. > > > > Here's the doc in progress: > > > > > https://wiki.evergreen-ils.org/doku.php?id=dev:angular_dev_best_practices > > > > Some of these are arbitrary, maybe not what we want, but I added them as > a > > starting point and because it's what I'm already doing (in most cases) > > anyway. > > > > I'm hoping a set of guidelines will ease the way for new developers and > > encourage consistency in coding, which helps everyone. > > > > Feel free to edit the doc and/or reply here with thoughts. > > > > Thanks, > > > > -b > > > -- > Jane Sandberg > Electronic Resources Librarian > Linn-Benton Community College > sand...@linnbenton.edu / 541-917-4655 > Pronouns: she/her/hers >