Hi, James,

Thanks, I've re-submitted the patches to use kref instead.

Best regards,

-----Original Message-----
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] 
Sent: Saturday, June 13, 2009 4:53 PM
To: Karen Xie
Cc: linux-s...@vger.kernel.org; open-iscsi@googlegroups.com;
Subject: Re: [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp

On Sat, 2009-06-13 at 14:29 -0700, k...@chelsio.com wrote:
> [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp usage
> From: Karen Xie <k...@chelsio.com>
> The iscsi ddp functionality could be used by multiple iscsi entities,
> add a refcnt to keep track of it, so we would not release it

The code is fine as it stands but, I wonder, would you consider using a
kref for this?  The reasons are twofold:

     1. It's a well understood kernel paradigm that works ... this would
        be helpful for the far distant time when chelsio no longer wants
        to maintain this driver.
     2. It includes useful and appropriate warnings for common bugs in
        refcounted code, such as use of a freed reference.


You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at http://groups.google.com/group/open-iscsi

Reply via email to