On 07/22/2009 09:01 AM, Erez Zilber wrote:
> Logging for connections and sessions in the scsi_transport_iscsi module
> is now controlled by module parameters.
>
> Signed-off-by: Erez Zilber<erezzi.l...@gmail.com>
>

Thanks! Looks good.

Just one comment. Sometimes there is a dbg statement after we do 
something that can fail like we have dbg statement after we alloc a 
session. Then sometimes we have a dbg statement before we do something 
like a add a device. Would it help if we put them at a consistent place? 
Maybe at the beginning and end of a function or maybe before and after 
we try to do something that can fail like allocation and dev addition or 
takes a while like scanning or target removal.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to