On Thu, Jul 30, 2009 at 6:37 AM, Mike Christie<micha...@cs.wisc.edu> wrote: > On 07/26/2009 08:48 AM, Erez Zilber wrote: >> I've attached a new version. I hope it's better. Whenever possible, >> there's a dbg statement before& after. For example, if we free the >> conn object, I can't put a dbg call after it (because conn is already >> NULL). If you still see specific things that need to be fixed, let me >> know. >> > > Thanks for the work on this. > > How about the attached. > - I added a ":" between the function name and debug output. > - Removed some extra newlines > - Tried to add dbg statements at the top and end of functions that can > take a long time or fail in odd ways because they call into the scsi > layer like the scanning, blocking, target removal, etc. For functions > like allocation, adding, destroying and freeing I tried to just add a > dbg statement at the top of end of the function. > > The patch was made over the linux-2.6-iscsi tree iscsi branch. >
Looks good. Thanks, Erez --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---
