On 3 Aug 2009 at 12:18, Mike Christie wrote: > > On 07/30/2009 01:08 AM, Ulrich Windl wrote: > > On 29 Jul 2009 at 21:50, Anil Veerabhadrappa wrote: > > > >> + bnx2i_ep->ep_iscsi_cid = (u16) -1; > > > > As a matter of style: Wouldn't it be more logical to write "(u16) ~0" > > instead? > > Casting a negative value to unsigned seems strange to me. > > > > Is there a MAX_U16 type of macro like there is for unsigned long?
In HP-UX <limits.h> I found # define USHRT_MAX 0177777 /* max value of a unsigned short int */ So maybe Linux has something similar for the kernel, but I don't know. Probably. Regards, Ulrich --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---
