>-----Original Message-----
>From: Ulrich Windl [mailto:ulrich.wi...@rz.uni-regensburg.de] 
>Sent: Monday, October 12, 2009 4:23 PM
>To: open-iscsi@googlegroups.com
>Cc: Chenault, Thomas; K, Narendra
>Subject: Re: iSCSI Connection failure with bnx2i transport
>On 29 Sep 2009 at 9:56, Benjamin Li wrote:
>> > -  memcpy(path_rsp->mac_addr, mac_addr, sizeof(mac_addr));
>> > +  memcpy(path_rsp->mac_addr, mac_addr, 6);
>Using unnamed constants looks like poor programming style. 
>Isn't there a symbolic name for that? Would 
>sizeof(path_rsp->mac_addr) work?

"ETH_ALEN" defined in  netinet/if_ether.h could be used provided it is
not redefined in future. 
I suppose  "sizeof(path_rsp->mac_addr)" would work too. The iscsi_path
structure defines mac_addr[6].
So I think even this can be replaced by "ETH_HLEN".

With regards,
Narendra K

You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at http://groups.google.com/group/open-iscsi

Reply via email to