On 01/24/2011 03:27 AM, Or Gerlitz wrote:
Mike Christie wrote:
Hey, I fixed this in the patches and put them in here:
http://git.kernel.org/?p=linux/kernel/git/mnc/linux-2.6-iscsi.git;a=shortlog;h=refs/heads/iscsi
Do you prefer that I send the entire patchset to the list? If so let me
I cloned the tree, built/booted with the iscsi branch, redirect works okay
with iser and the persistent/current portals are reported fine, cool, thanks,
this can go upstream, sure, I assume you'll send it to James and he either get
it to .38 or .39, makes sense? I'd like to be queued asap so we can push it
further
to distros, etc.
.39. I am still waiting on test results from others, so I think by the
time they are done it will be late in .38
The relevant iser changes are:
http://git.kernel.org/?p=linux/kernel/git/mnc/linux-2.6-iscsi.git;a=commit;h=00320bcd5467a6cbb2d55f7c1dbf85128bc072ea
http://git.kernel.org/?p=linux/kernel/git/mnc/linux-2.6-iscsi.git;a=commit;h=9259584189c8b9731b210b05dfdafc0483ab9554
thanks, please just run spelling and add your signature to the change log of
the iser patch (replace "pactch" with "patch"),
I just added a mutex around the reading of conn params and around some
state bits that indicated if the ep is getting disconnected. This way
the LLD does not have to worry. It knows that the get param callout will
not get called if ep disconnect has been called. And ep disconnect waits
for a get param to finish before calling into the driver to tear down the ep.
I wasn't sure about the new patch/approach to the ep leak on iscsid restart
(below),
is this correct that this patch (and maybe more patches from your tree) replaces
the "[PATCH 2/3] iscsi: fix iscsi_endpoint leak" you sent earlier? The one you
sent are removing the "is_leading" and touching the iser bind code wheres this
doesn't
is it all okay or something was forgotten?
It is ok.
It is same approach for the fix where the iscsi class detects the leak
and forces cleanup. The only changes are that in the patch on the list,
I had included other non-related changes to make it easier to test (I
actually did not mean to post the [PATCH 2/3 and 3/3 to the list. I
thought I aborted the git-send-email, but only the [PATCH 1/3 got
aborted), and I had libiscsi track the ep/conn binding.
The leading conn/is_leading change is more of a cleanup. It had nothing
to do with the leak. We always have is_leading set to 1, because we only
support single connection sessions. I was thinking I should just remove
it, but then I thought for LIO target mode we can support MC/s so maybe
one day we can support it in the initiator again (who knows though).
The other change is where iscsi_conn_bind set the iscsi_endpoint and
iscsi_cls_conn pointers to each other (that required me to also move the
ordering of the ep lookup and iscsi_conn_bind call in iser because
iscsi_conn_bind required the caller to pass the ep). I decided to move
that management to the iscsi class, because the iscsi class was the one
that was actually using those pointers to track the state, and libiscsi
did not really have any idea what was going on.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
