On 06/24/2011 06:05 AM, Ulrich Windl wrote: >>>> Hannes Reinecke <[email protected]> schrieb am 21.06.2011 um 09:24 in Nachricht > <[email protected]>: > > [...] >> diff --git a/usr/log.c b/usr/log.c >> index 62500cb..2eeee8e 100644 >> --- a/usr/log.c >> +++ b/usr/log.c >> @@ -458,6 +458,8 @@ void log_close(pid_t pid) >> return; >> } >> >> - kill(pid, SIGTERM); >> - waitpid(pid, &status, 0); >> + if (pid > 0) { >> + kill(pid, SIGTERM); > > Wondering (just paranoid): if (pid > 0 && kill(pid, SIGTERM) == 0) /* now we > actually sent a signal, and it makes sense to wait for PID to terminate */
Yeah, I think you are right. I will fix that up for Hannes's patch with a follow up patch. Thanks. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
