On 07/22/2011 12:09 PM, Vivek S wrote:
> Changed the way iscsiadm displays usage help about its commands. Rather than 
> simply displaying each possible mode along with its options on a single 
> line,
> the user can now ask help for each mode separately which describes the 
> various options and also provides some examples.
> 


> +        printf("\n");
> +        switch (mode)
> +        {
> +            case MODE_DISCOVERYDB:
> +                printf("iscsiadm -m discoverydb [options...]\n\n");
> +                options = CMD_LINE_OPTION_PORTAL | CMD_LINE_OPTION_IFACE | 
> CMD_LINE_OPTION_OP \
> +                

Not sure if it is the mailer but just try to keep things around 80
columns in the code like the other code is doing unless it is a string
and breaking it up makes it more difficult to read.

For example if you hit 80 cols in the middle of a target name
"iqn.2005-06.com.mydomain.openiscsi.test1" then I would not split that
up into "iqn.2005-06.com.mydom" and "ain.openiscsi.test1" just to make
it 80 cols.

But, something like the above could be

options = CMD_LINE_OPTION_PORTAL | CMD_LINE_OPTION_IFACE | \
                CMD_LINE_OPTION_OP \

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.

Reply via email to