On 09/03/2011 04:02 AM, Vivek S wrote:
> Any update ?
>
Looks ok. Thanks for all your work on it. And thanks to Ulrich for the
review.
Just one stye comment though. The coding style we follow has us put the
leading "{" on the first line for structs, for, and if/else blocks. So
+struct option_help
+{
would be
+struct option_help {
+ if ( (str_len + (num_tabs * TAB_WIDTH) - num_tabs) > max_cols )
+ {
would be
if ( (str_len + (num_tabs * TAB_WIDTH) - num_tabs) > max_cols ) {
Also in here you do not need the extra spaces between the ((s and at the
end after max_cols and )
And
+ }
+ else
+ {
would be
} else {
then here
+ for (i=0 ; i<str_len ; i++)
+ {
you want spaces between i and = and 0 and i and < and str_len but not
after str_len so it should be
for (i = 0 ; i < str_len; i++)
If there is only one line and so {} are not needed then we do not add them
+ if (ioctl(0,TIOCGWINSZ,&ws)!=0)
+ {
+ return 80;
+ }
should be
if (ioctl(0,TIOCGWINSZ, &ws) != 0)
return 80;
I will fix these up when I merge it. I am having troubles logging into
kernel.org to update the git tree due to the breakin.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
