Yeah, I am fine with adding the GPL2 headers. Thanks for the merging.
Regards,
Aastha.
On 4 October 2011 06:44, Mike Christie <micha...@cs.wisc.edu> wrote:
> On 09/08/2011 07:23 AM, Ankit Jain wrote:
> > On Thu, Sep 8, 2011 at 2:26 PM, Aastha Mehta <aasth...@gmail.com> wrote:
> >> Sorry, please ignore the previous patch. There was some minor error in
> that.
> >> Re-attaching the patch here.
> >
> > +#include<stdio.h>
> > +#include<stdlib.h>
> > +#include<string.h>
> > +#include "iscsi_if.h"
> > +#include"kern_error_table.h"
> > +#define NUM_ERRORS 22
> >
> > You can probably clean up the includes, and the #define.
> >
> > + log_warning("error %d: %s ", error, err_desc);
> > Maybe do:
> > log_warning("error %d: %s ", error, err_code_to_string(error);
> >
> > + switch(code % ISCSI_ERR_BASE){
> > + case 0: return "ISCSI_OK: operation successful";
> > + case 1: return "ISCSI_ERR_DATASN: Received invalid
> > data sequence
> > number from target";
> >
> > Since you are returning the error strings here directly, you don't need
> > "code % ISCSI_ERR_BASE" and can use ISCSI_ERR_* enum values
> > in the case statements directly. That would be clearer than using just
> > numbers.
> >
> > + default: return "Invalid error code. Is there a new error
> code
> > added which is not handled?";
> >
> > "Invalid" or "Unknown" ? This is probably nitpicking :/
> >
>
> I think these are all good suggestions. Thanks for the review. I merged
> them into the almost final patch attached.
>
> Aastha, is ok to add the GPL2 headers on the files you are adding like
> is done in the other files? Many distros requires that all files have
> some sort of header like that.
>
> --
> You received this message because you are subscribed to the Google Groups
> "open-iscsi" group.
> To post to this group, send email to open-iscsi@googlegroups.com.
> To unsubscribe from this group, send email to
> open-iscsi+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/open-iscsi?hl=en.
>
>
--
Aastha Mehta
B.E. (Hons.) Computer Science
BITS Pilani
E-mail: aasth...@gmail.com
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
