Hello Mike, Yes, I think it would be beneficial to add the passing of the iface_num parameter to the transport's ep_connect call so that it can identify which iface profile to use. This should help HW transports that have support for more than one iface profile.
For bnx2i in particular, this iface_num handle will then get passed to iscsiuio for iface identification. Thanks, Eddie On Tue, 2012-01-03 at 13:53 -0600, Mike Christie wrote: > Eddie, > > Did you say you were going to make some changes to the ep_connect path > for bnx2i? > > On 01/03/2012 01:05 PM, Or Gerlitz wrote: > > Hi Mike, > > > > Resending, could you please look on that? (and happy new year) > > > > Or. > > > > ---------- Forwarded message ---------- > > From: Or Gerlitz <[email protected]> > > Date: Thu, Oct 27, 2011 at 12:55 PM > > Subject: using iface attributes for no HW iscsi transport > > To: Mike Christie <[email protected]>, [email protected] > > > > Mike, yes, it could be RTFM question, if indeed this is the case, just > > point me to the-M > > portion or to some area of the code.. its been a while since we realized > > that iser needs > > some attributes from user space to the time ep_connect is called. > > > > Quick examples are the source ip address for multi-pathing (e.g when done > > on 2 paths > > who use the same IP subnet), the maximal number of SCSI commands to be used > > for that > > session, vlan proirity for the case of this session being on IBoE > > environment and > > this IP subnet being served by 8021q vlan nic, etc. > > > > For the most case, these attributes are present in the iface structure. > > > > I see that for HW iscsi, the iface attributes are sent down to the kernel > > and kept there, for example in the qla4xxx code, I see that flow > > qla4xxx_iface_set_param --> qla4xxx_set_ipv4 ... --> > > qla4xxx_update_local_ifcb > > to set attributes such as source ip, vlan, etc. Later in ep_connect, I > > wasn't sure > > to realize if/how these settings are used, but I'm sure they are at some > > point (maybe > > earlier, when the scsi host is created I think at that point the > > session/connection > > are set already by HW iscsi drivers). > > > > So iser isn't HW iscsi driver, but we still be happy (need) to be able to > > use > > the iface mechanism for params required for the iser RDMA connection > > setting. > > > > What would be the way to achieve that? is that fully supported by user space > > and I just have to implement some kernel patches in iser and maybe in the > > iscsi > > transport code as well, or its change in the user space state-machine as > > seen > > @ > > http://www.open-iscsi.org/**docs/open-iscsi-1.jpg<http://www.open-iscsi.org/docs/open-iscsi-1.jpg> > > > > In the past you mentioned the possibility for ep_connect_ext API, is that > > what need > > to be done here? > > > > thanks, > > > > Or. > > > > The latest code I'm looking at is from > > > > kernel git://git.kernel.org/pub/scm/**linux/kernel/git/jejb/scsi-** > > misc-2.6.git<http://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git> > > user/kernel > > git://github.com/mikechristie/**open-iscsi<http://github.com/mikechristie/open-iscsi> > > > > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
