Mike Christie <[email protected]> wrote: > Yeah, I was just wondering if you knew all the ones you needed.
Again, I surely need / must have the source IP address if its specified in the iface used for the login. The other two params which I've mentioned are also needed in some cases, as for "all the ones you needed" I think we should look for a way which will allow for more params to be provided down the road, e.g using an interface or a like profile. > In the kernel you could implement a iscsi_transport->set_iface_param. > Userspace could then just pass down whatever is needed. The problem is > that as it is now, the drivers allocate a host per resource then under > that a iface per whatever the user/hw defines (user might do it per > iscsi port, hw might do it per source ip address or some other resource). again (and you actually noted), in that respect, iser is like the tcp transport, host per iscsi session, I think we should keep workig this way. > We could do: > > 1. Change iser to allocate a host per port or something like is done > with the other drivers except iscsi_tcp. Userspace would then just call > set_iface_param to create a iface and pass down the settings needed. > > With Eddies change to include the iface num in ep_connect then when that > ep_connect is called we just match that iface num and bind at that time. > > 2. iser could implement a set_iface_param callout and when it is called > to pass down settings it could also allocate a scsi_host and iface. When > ep_connect is called it gets passed the scsi_host, so you have the iface > info. > > You could either make this one allocate a host per iface or you could do > it so it allocates a host per session still. For the latter you would > just have duplicate ifaces/hosts (if you allocated a new one per session > like is done today for host per session) or you need some code to manage > them (do something so we can match existing ifaces in the driver). I prefer to stay in the host per session model. I wasn't sure to follow on the last few sentences specifically not the "duplicate ifaces/hosts > 3. Add new ep_connect call that passes down the current info and all the > params you need. #3 would be the easiest but maybe not extends well towards adding future params. > 4. ? > I think I might like #2 best. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
