-----Original Message----- From: Mike Christie <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Wednesday 7 November 2012 11:39 AM To: Lalit Chandivade <[email protected]> Cc: Vikas <[email protected]>, "[email protected]" <[email protected]>, Ravi Anand <[email protected]>, Adheer Chandravanshi <[email protected]> Subject: Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs.
>On 11/04/2012 11:17 PM, Lalit Chandivade wrote: >> Mike, >> >> The related options are clubbed as a bit map, each bit means something >>within an option. >> I am trying to give few examples for each option, >> >> + FLASH_TGT_OPTIONS, >> This is an IPv6 target >> This is a discovery target (send target) >> >> + FLASH_TGT_ISCSI_OPTIONS, >> Data Digest is enabled >> Header Digest is enabled >> >> + FLASH_TGT_TCP_OPTIONS, >> Disable TCP Scale Window >> >> + FLASH_TGT_IP_OPTIONS, >> Disable Fragmentation > >Did I misread the code? The defs for the bits are qla specific right now >right? I am just asking to move the definitions for the bits to the >iscsi_flash_sysfs code, so it is usable and defined for all drivers that >use the interface. It should be such that if we have a qla4xxx target >and a be2iscsi target then writing the same bitmap to the options file >turns/off the same features Mike, We modified code as per you comments to make it more generic. I am sending RFC_V2 of kernel patched in next email. We are still working on iscsiadm code. Thanks, Vikas. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
