>>> Mike Christie <[email protected]> schrieb am 06.04.2013 um 09:13 in
Nachricht <[email protected]>:
> On 4/5/13 6:34 AM, [email protected] wrote:
> > From: Vikas Chaudhary <[email protected]>
> >
> > Signed-off-by: Vikas Chaudhary <[email protected]>
> > ---
> >   usr/session_info.c | 24 +++++++++++++++++++-----
> >   1 file changed, 19 insertions(+), 5 deletions(-)
> >
> > diff --git a/usr/session_info.c b/usr/session_info.c
> > index 1f84c49..17c5de8 100644
> > --- a/usr/session_info.c
> > +++ b/usr/session_info.c
> > @@ -64,20 +64,32 @@ void session_info_free_list(struct list_head *list)
> >     }
> >   }
> >
> > +static char *get_iscsi_node_type(struct session_info *info)
> > +{
> > +   int pid = iscsi_sysfs_session_user_created(info->sid);
> > +
> > +   if (!pid)
> > +           return "(flashnode)";
> > +
> > +   return "";
> > +}
> > +
> 
> If someone is parsing this and we add another string after this one, 
> then they are going to have a difficult time handling "". Can you think 
> of a name for the non-flashnode type? I can just edit that into the 
> patch when I merge it.
> 
> Software-node? Something?

Hi!

The asnwer may be more easy if someone would explain ``what is as 
"flashnode"?'' Once knowing that, it's easier to describe what a non-flashnode 
is ;-)

Regards,
Ulrich


-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to