We wanted to associate the 'iscsiadm -m node' mode and 'iscsiadm -m host -H X -C flashnode' mode to differentiate session. So displaying "node" and "flashnode" would be easier to co-relate who created the session.
Mike, Also let us know your views for this. Thanks, Vikas. -----Original Message----- From: Ulrich Windl <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Monday 8 April 2013 6:19 PM To: "[email protected]" <[email protected]> Subject: Antw: Re: [PATCH 2/2] iscsi tools: Print additional session info for flashnode session >What about "normal" vs. "flash" (maybe not repeat "node" in node context)? > >>>> Vikas Chaudhary <[email protected]> schrieb am 08.04.2013 um >>>>11:19 in >Nachricht <[email protected]>: > >> >> -----Original Message----- >> From: Mike Christie <[email protected]> >> Reply-To: "[email protected]" <[email protected]> >> Date: Saturday 6 April 2013 12:43 PM >> To: Vikas <[email protected]> >> Cc: "[email protected]" <[email protected]>, Lalit >> Chandivade <[email protected]>, Ravi Anand >> <[email protected]> >> Subject: Re: [PATCH 2/2] iscsi tools: Print additional session info for >> flashnode session >> >> >On 4/5/13 6:34 AM, [email protected] wrote: >> >> From: Vikas Chaudhary <[email protected]> >> >> >> >> Signed-off-by: Vikas Chaudhary <[email protected]> >> >> --- >> >> usr/session_info.c | 24 +++++++++++++++++++----- >> >> 1 file changed, 19 insertions(+), 5 deletions(-) >> >> >> >> diff --git a/usr/session_info.c b/usr/session_info.c >> >> index 1f84c49..17c5de8 100644 >> >> --- a/usr/session_info.c >> >> +++ b/usr/session_info.c >> >> @@ -64,20 +64,32 @@ void session_info_free_list(struct list_head >>*list) >> >> } >> >> } >> >> >> >> +static char *get_iscsi_node_type(struct session_info *info) >> >> +{ >> >> + int pid = iscsi_sysfs_session_user_created(info->sid); >> >> + >> >> + if (!pid) >> >> + return "(flashnode)"; >> >> + >> >> + return ""; >> >> +} >> >> + >> > >> >If someone is parsing this and we add another string after this one, >> >then they are going to have a difficult time handling "". Can you think >> >of a name for the non-flashnode type? I can just edit that into the >> >patch when I merge it. >> > >> >Software-node? Something? >> >> >> How about writing just "node", as these session are created with mode >>node? >> >> output will look like:- >> >> root@localhost: [usr (to_scsi_list_v2)]# ./iscsiadm -m session >> qla4xxx: [11] 192.168.1.11:3260,1 >>iqn.1992-04.com.emc:cx.ckm00101200392.a2 >> (flashnode) >> qla4xxx: [12] 192.168.1.8:3260,3 >>iqn.1992-04.com.emc:cx.ckm00101200392.a3 >> (flashnode) >> qla4xxx: [13] 192.168.1.12:3260,2 >>iqn.1992-04.com.emc:cx.ckm00101200392.b2 >> (flashnode) >> qla4xxx: [14] 192.168.1.9:3260,4 >>iqn.1992-04.com.emc:cx.ckm00101200392.b3 >> (flashnode) >> qla4xxx: [15] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.0 >>(node) >> qla4xxx: [16] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.2 >>(node) >> qla4xxx: [17] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.1 >>(node) >> qla4xxx: [18] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.3 >>(node) >> qla4xxx: [19] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.4 >>(node) >> >> >> >> Thanks, >> Vikas. >> >> >> ________________________________ >> >> This message and any attached documents contain information from QLogic >> Corporation or its wholly-owned subsidiaries that may be confidential. >>If you >> are not the intended recipient, you may not read, copy, distribute, or >>use >> this information. If you have received this transmission in error, >>please >> notify the sender immediately by reply e-mail and then delete this >>message. > > > > > >-- >You received this message because you are subscribed to the Google Groups >"open-iscsi" group. >To unsubscribe from this group and stop receiving emails from it, send an >email to [email protected]. >To post to this group, send email to [email protected]. >Visit this group at http://groups.google.com/group/open-iscsi?hl=en. >For more options, visit https://groups.google.com/groups/opt_out. > > > ________________________________ This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
