On 05/08/2013 05:52 PM, The Lee-Man wrote:
>
> - if (name && value) {
> + if ((mode == MODE_IFACE ||
> + (mode == MODE_HOST && sub_mode ==
> MODE_FLASHNODE)) &&
> + name && value) {
> param = idbm_alloc_user_param(name, value);
> if (!param) {
> log_error("Cannot allocate memory
> for params.");
>
>
> I believe this is incorrect. After your patch, "name" and "value" will
> not be set in MODE_NODE.
>
> Should that be "if (mode == MOD_IFACE || mode == MODE_NODE ||" ?
>
> @@ -2603,7 +3007,7 @@ main(int argc, char **argv)
Thank you so much for helping to review! You are right.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
