On Thursday, May 9, 2013 5:03:44 AM UTC-7, Adheer Chandravanshi wrote: > > > -----Original Message----- > > From: Mike Christie [mailto:[email protected] <javascript:>] > > Sent: Thursday, May 09, 2013 7:31 AM > > To: [email protected] <javascript:> > > Cc: The Lee-Man; Vikas Chaudhary; Lalit Chandivade; Ravi Anand; Poornima > > Vonti; Manish Rangankar; Adheer Chandravanshi > > Subject: Re: [PATCH 1/3] iscsiadm: Add flash node mgmt support. > > > > On 05/08/2013 05:52 PM, The Lee-Man wrote: > > > > > > - if (name && value) { > > > + if ((mode == MODE_IFACE || > > > + (mode == MODE_HOST && sub_mode == > > > MODE_FLASHNODE)) && > > > + name && value) { > > > param = idbm_alloc_user_param(name, > value); > > > if (!param) { > > > log_error("Cannot allocate memory > > > for params."); > > > > > > > > > I believe this is incorrect. After your patch, "name" and "value" will > > > not be set in MODE_NODE. > > > > > > Should that be "if (mode == MOD_IFACE || mode == MODE_NODE ||" ? > > > > > > @@ -2603,7 +3007,7 @@ main(int argc, char **argv) > > > > Thank you so much for helping to review! You are right. > > Mike, > > Please find the patch attached herewith that fixes the issue reported by > Lee. > > Thanks, > Adheer > > > Looks good to me, and tested as well.
Acked-by: Lee Duncan <[email protected]> > > ________________________________ > > This message and any attached documents contain information from QLogic > Corporation or its wholly-owned subsidiaries that may be confidential. If > you are not the intended recipient, you may not read, copy, distribute, or > use this information. If you have received this transmission in error, > please notify the sender immediately by reply e-mail and then delete this > message. > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
