>>> Mike Christie <[email protected]> schrieb am 01.02.2014 um 06:14 in
Nachricht <[email protected]>:
> On 1/26/14 8:03 AM, Or Gerlitz wrote:
>> For proper discovery support, the iser transport needs the
>> ISCSI_PARAM_DISCOVERY_SESS hint before the login PDU is sent.
>>
>> For that end, issue the call to iscsi_session_set_params before
>> starting the login code in case the transport is iser.
>>
>> Signed-off-by: Or Gerlitz <[email protected]>
>> ---
>> usr/discovery.c | 13 ++++++++++++-
>> 1 files changed, 12 insertions(+), 1 deletions(-)
>>
>> diff --git a/usr/discovery.c b/usr/discovery.c
>> index afce6c0..4f02aac 100644
>> --- a/usr/discovery.c
>> +++ b/usr/discovery.c
>> @@ -1116,7 +1116,7 @@ static int iscsi_create_leading_conn(struct
> iscsi_session *session)
>> }
>>
>> /* create interconnect endpoint */
>> - log_debug(2, "%s discovery ep connect\n", __FUNCTION__);
>> + log_debug(2, "%s discovery ep connect transport %s caps %x\n",
> __FUNCTION__, t->name, t->caps);
>
> Formatting. You kept it one line here but you tried to break it up
> below. You should try to follow the existing code.
Though it's not relevant, my personal coding style for printf-like statements
(like the one above) that don't fint in one 80-character line is to wrap the
line preferrably between format string and actual output parameters. To too
seldom you cahnge either the format or the parameter independently. For very
long format strings I use the ANSI-C string concatenation ("you know" " what I
mean") on seperate lines. Just my opinion on style...
Ulrich
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/groups/opt_out.
