On 01/08/2015 11:11 AM, Chris Leech wrote:
> On Thu, Jan 08, 2015 at 10:36:59AM -0600, Michael Christie wrote:
>>
>> On Jan 6, 2015, at 6:40 PM, Chris Leech <[email protected]> wrote:
>>
>>> Hi all,
>>>
>>> It looks to me that the changes in "iscsid: retry login for
>>> ISCSI_ERR_HOST_NOT_FOUND" have broken interface binding for iscsi_tcp
>>> (and iser, assuming interface bindin
>>
>> iser does not do binding.
>
> Thanks for clearing that up, less to worry about then.
>
>>
>> Is this a regression with the patch:
>>
>> commit c0e509e7535372cd5d655bc5a20d3d2bae45df84
>> Author: Mike Christie <[email protected]>
>> Date: Wed May 7 14:38:13 2014 -0500
>>
>> iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND
>
> Yes, it looks that way to me.
>
Didn't you have a patch to add some flag on the iscsi_transport struct
in userspace that indicated if it was a offload driver or something like
bind_ep was required? I think you sent it to me, when I was at my old job.
Instead of trying to be cute and detect it, then we could just do your
patch and modify this test:
} else if (*rc == ISCSI_ERR_HOST_NOT_FOUND &&
t->bind_ep_required) {
goto free_session;
Or, I guess maybe it is better to check before, so do:
if (t->bind_ep_required) {
host_no = iscsi_sysfs_get_host_no_from_hwinfo(iface, &rc);
......
}
We can then update transport.c and remove the "session->conn[0].bind_ep
= 1;" lines.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
