On Sat, Feb 13, 2016 at 05:30:03PM -0600, Mike Christie wrote: > On 02/12/2016 06:05 PM, Christian Seiler wrote: > > Hi, > > > > Debian is currently working on making the entire archive build > > reproducibly. <https://reproducible-builds.org/> is a good > > resource describing the motivation behind this effort. > > > > There was one problem that was found in the open-iscsi package > > build system that prevented builds from being reproducible: > > the list of object files generated by the wildcard Makefile > > function are not in a deterministic order, causing changes in > > the output depending on the order in the underlying filesystem. > > > > I've attached a patch against the current git master that > > sorts the list of object files within the Makefile, making the > > order deterministic and allowing reproducible builds to be > > made. See also: > > <https://reproducible-builds.org/docs/stable-inputs/> > > > > It would be great if you could apply this patch upstream, so we > > don't have to carry it in Debian. > > > > Lee and Chris, > > The patch seems fine to me. It will not break SUSE or Red Hat build > stuff will it?
Looks good to me, I don't see it causing any problems. - Chris -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
