On Sun, Oct 02, 2016 at 12:34:31PM +0200, Christian Seiler wrote: > Hi again, > > Many thanks for merging PR #29 and adding them to 2.0.874. > > I'd still like to hear your thoughts on the two other things I > mentioned here: > > On 09/18/2016 06:42 PM, Christian Seiler wrote: > > We carry an additional patch in Debian that removes the callout to > > the kernel subdirectory in 'make clean'. Otherwise, make clean > > would fail in build environments, because no kernel source would > > be installed there. (And Debian's packaging tools always call make > > clean during build before building the source.) > > I would again propose to just remove the kernel/ subdirectory > from the tree, because the kernel code is now upstream, and > people needing the patches for really old kernels can just > grab an old release of open-iscsi, it's not like the kernel > patches are updated anymore. (I'd expect that the current code > in there contains quite a few bugs that have been fixed for a > long time in the upstream kernel.) > > Finally, there's also this: > > > Furthermore, we have an additional patch in Debian that replaces > > /var/run with /run and /var/lock with /run/lock; I realize that > > not all distributions have done this change though, so would you > > be willing to take an extra patch that would allow to pass in > > these directories via the build system? (And use the /var ones > > if nothing is specified.) > > Would you be agreeable to that? > > I can create pull requests for both of these things.
Now that all the previous work has been tagged as a release, there are a bunch of tree clean up tasks that I think would be worth doing. - Removing the old kernel code - Removing the stub code for BSD. We have escaped the interface abstractions and become heavily Linux only and that's not going to change. - Build system improvements. We could switch everything to autotools if needed, but there are some directory things that distros are patching that should be configurable with whatever build system we use. - Look at what distros are doing in systemd unit files and try to get a better set of those standard in the upstream release. Chris -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
