> At the same time, I fixed a few cosmetic issues and updated the > version to 0.97.
Unfortunately, that broke ABI for the shared library (if that's enabled via --enable-shared), by replacing all references to 0.96 in the version script with 0.97. That's not how version scripts work - and if I now compile the shared library and install it, all programs linked against 0.96 would immediately fail to load (symbol version not found), even though nothing in the code is actually incompatible. If a new public function had been added in 0.97 one would add a new section to the version script with that specific function, to clearly indicate that that function was added in 0.97. But as long as current functions remain compatible, their version tag should _not_ change. (When I sent the original pull request for the shared library support including symbol versioning, I added a comment to the top of the version script with some information on how the file works.) Could you revert the libisns.vers change back to 0.96 as there were no symbol changes (looking over the git changes)? And maybe release 0.97a or 0.97.1 or so with that fixed? (Just a new tarball/tag, there doesn't have to be a change in the source code, that can still call itself 0.97, because the code is still the same.) (In general, I'd be happy to maintain the version script and the shared library stuff in open-isns so you don't have to care about that - I did add that and I'm probably the primary user of that by means of the Debian packaging - but I would need a bit of a heads-up before a release.) Regards, Christian -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
