No comment on these? Since the previous version drew comments, can I assume 
that means everybody is happy with this version?

Hannes? Anyone?


> On Nov 23, 2016, at 2:58 PM, leeman.dun...@gmail.com wrote:
> 
> From: Lee Duncan <ldun...@suse.com>
> 
> This set of two patches addresses the issues
> I mentioned on the mailing list recently relating
> to how systemd can interfere with shutting down
> the iscsid daemon. The iscsiadm command "-k"
> can hang if the daemon is not present, when
> running under systemd, when socket activated.
> 
> The first patch, from Hannes, modifies the IPC
> communications so that user-level commands, like
> iscsiadm and iscsistart, do not hang when waiting
> for a response from the iscsid daemon by using
> the poll() system call. This version also has a
> couple of small bug fixes on top of the version
> that Hannes posted recently.
> 
> The second patch modifies iscsid to treat a
> SIGTERM just like it had received the "immediate
> stop" command from iscsiadm (via the "-k"
> option), simplifying the shutdown of iscsid so
> that it no longer requires IPC communications.
> 
> Changes since v3:
> * reworked the second patch to just set the
>   "exit the polling loop" flag
> 
> Changes since v2:
> * updated first patch to rework poll() logic
> 
> Changes since v1:
> * added 2nd patch
> * fixed 2 spots in the first patch
> 
> Hannes Reinecke (1):
>  Use timeout when waiting for responses from iscsid
> 
> Lee Duncan (1):
>  iscsid: treat SIGTERM like "iscsiadm -k 0"
> 
> usr/config.h       |  1 +
> usr/discovery.c    | 16 ++++++++--------
> usr/host.c         |  2 +-
> usr/iscsi_sysfs.c  |  1 +
> usr/iscsiadm.c     | 12 +++++++-----
> usr/iscsid.c       |  5 ++---
> usr/iscsid_req.c   | 51 +++++++++++++++++++++++++++++++++++++++++----------
> usr/iscsid_req.h   | 15 +++++++++------
> usr/iscsistart.c   |  4 ++--
> usr/session_info.c | 14 ++++++++------
> usr/session_info.h |  5 +++--
> 11 files changed, 83 insertions(+), 43 deletions(-)
> 
> -- 
> 2.1.4
> 



--
Ignore the Lee-Man behind the curtain ...

"Life's a long song. But the tune ends too soon for us all." -- Ian Anderson

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to