On 11/29/2016 01:01 AM, Lee Duncan wrote: > No comment on these? Since the previous version drew comments, can I > assume that means everybody is happy with this version?
>From a Debian maintainer perspective, I'd be happy with it. Only minor thing is that you might want to mark static int event_loop_stop; (usr/event_poll.c) to be volatile, to be on the safe side when modifying it from within a signal handler. Probably not really required here (the compiler is not allowed to optimize out the access anyway, since you call non-static functions within the loop), but it doesn't hurt either, just in case... Regards, Christian -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
