On 07/03, Chris Leech wrote: > On Tue, Feb 21, 2017 at 08:40:47PM +0100, Gorka Eguileor wrote: > > On 21/02, Chris Leech wrote: > > > > 4- Add a specific configuration option for the sessions to disable > > > > automatic scans, as proposed by the patch. > > > > > > > > Pros: Finer grain control than any other option since we have per > > > > session configuration. > > > > > > > > Cons: We have to add a configuration option to iscsid. > > > > > > > > I believe option 1 and 4 and the most reasonable. With option 1 > > > > favoring not having to add a configuration parameter over finer control > > > > of scans, and option 4 doing the opposite. > > > > > > > > I think that finer control of the scans is preferable (changing the > > > > parameter name in the patch to "scan", with acceptable values "auto" and > > > > "manual" instead) over using the scsi_mod configuration, but if adding > > > > another configuration option is not acceptable I am willing to modify > > > > the patch to use the other approach. > > > > > > That sounds good to me. > > > > > > Want to take a shot at renaming things to better align with the > > > scsi_mod.scan parameter where it makes sense? > > > > > > - Chris > > > > Hi Chris, > > > > Thanks, I have updated the patch and the PR message  accordingly. > > They should now be following a closer naming to scsi_mod. > > Thanks, for the revision. > Since there are no other objections, I'm merging this now. > > Chris > > -- > You received this message because you are subscribed to the Google Groups > "open-iscsi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to open-iscsi+unsubscr...@googlegroups.com. > To post to this group, send email to email@example.com. > Visit this group at https://groups.google.com/group/open-iscsi. > For more options, visit https://groups.google.com/d/optout.
Thanks!! This will be a great help for the OpenStack projects Cinder and Nova. Cheers, Gorka. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to firstname.lastname@example.org. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.