> So we could just add a CAP_SCSI_EH_TRANSPORT OFFLINE flag to > the iscsi_transport->caps struct. When userspace sees that then > it knows the kernel will now do the right thing. > > The drawback is that we have to patch userspace and then also > get the the new CAP_SCSI_EH_TRANSPORT_OFFLINE patch in the stable > kernels.
Another drawback of this approach is that we are covering up a bug in the kernel, which is still possible to hit if someone/something besides iscsid decides to write to the sysfs state field at the unlucky timing. Not sure how much we care about this. If it's considered a non-issue, then I'll put together the change you described and send it to linux-scsi as well. Thanks, Uday -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/20220829215122.GA546808%40dev-ushankar.dev.purestorage.com.
