On 8/29/22 9:21 PM, [email protected] wrote: > On 8/29/22 4:51 PM, Uday Shankar wrote: >>> So we could just add a CAP_SCSI_EH_TRANSPORT OFFLINE flag to >>> the iscsi_transport->caps struct. When userspace sees that then >>> it knows the kernel will now do the right thing. >>> >>> The drawback is that we have to patch userspace and then also >>> get the the new CAP_SCSI_EH_TRANSPORT_OFFLINE patch in the stable >>> kernels. >> >> Another drawback of this approach is that we are covering up a bug in >> the kernel, which is still possible to hit if someone/something besides
Oh yeah, I don't think the list of programs that can hit this problem is very long. It's a iscsi only problem right? So there's open-iscsi, some boot tool in go, and google's tools that we know of. I think only open-iscsi will have the problem too. You won't hit it in other transports because only iscsid tries to online the device from userspace from the same thread that is needed to relogin and unblock a device. FC/SAS/SRP don't have the same problem since they do the block and unblock from kernel workqueues which will run independently from some userspace thread writing to sysfs. Or, is there other ways to hit this that you are seeing? If there are then forget what I wrote in the last mail :) -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/e5f7ba9f-8268-c0bd-7a60-f702157ab6a7%40oracle.com.
