Re: svn commit: r502392 - /incubator/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/AbstractBrokerFactory.java

[Craig L Russell]

Hi Kevin,

Good changes.

Here's where I would have put a comment:

On Feb 1, 2007, at 2:53 PM, [EMAIL PROTECTED] wrote:

             Broker broker;

                 broker = (Broker) itr.next();
-                if (!broker.isClosed())

for (Iterator itr = _brokers.iterator(); itr.hasNext ();) {

/* Check for null here because _brokers is a weak reference collection */

+                if ((broker != null) && (!broker.isClosed()))
                     broker.close();

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

smime.p7s
Description: S/MIME cryptographic signature