On 8/18/08, Adar Dembo <[EMAIL PROTECTED]> wrote:
>
> > This is my patch for 2008.08.08 release. This patch adds a
> > simple "Record" panel to vmware-toolbox and "record" command
> > to vmware-toolbox-cmd.
> > I configured the build by "--without-procps --disable-unity",
> > since I didn't install the two packages.
> > I have tested the patch on rhel5, suse10 and ubuntu7.04.
>
> Thanks! I haven't reviewed the entire patch yet, but here are some
> suggestions to get started:
> - Please clean up your patch and make it conform to the open-vm-tools
> coding style. You can see the coding style here:
> http://open-vm-tools.wiki.sourceforge.net/CodingStandards. If something is
> unclear or ambiguous, feel free to ask. Some specific things I immediately
> noticed:
> - Configure your editor to use levels of indentation sized to 3 spaces.
> - No tabs; use an appropriate number of spaces instead.
> - Continuation lines should obey the nesting of parenthesization.
> - All arguments to new functions should have comment annotations next to
> them (such as IN, OUT, or IN/OUT).
> - New copyright preambles should be dated to 2008.
> - The second line in the RecordCommand function header's "Side effects"
> section needs more indentation.
Thank you for your comment. I will double check.
- I gather that you're familiar with the subcommands of the
> BDOOR_CMD_STATELOGGER backdoor command through working with internal
> engineers? I'm going to try and get the actual header documenting the
> commands released so that you need not hard-code the values 1 and 2 in calls
> to Record_Control.
> - I think Record_Control should actually be in lib/guestApp/guestApp.c, not
> in toolboxcmd-record.c. I'd rather that the GTK toolbox didn't depend on any
> toolboxcmd* files, since the toolbox* and toolboxcmd* group of files can be
> considered to be separate UI front-ends to a shared back-end.
This is the point. I was trying to give it a proper place but I was not sure
which lib it should be. Thanks.
> I get the contribution agreement document, but I am not sure
> > if paper form or electronic form is required.
>
> The agreement should be faxed or scanned and e-mailed.
> http://open-vm-tools.sourceforge.net/contribute.php has more information;
> choose whichever method is more convenient for you, and let me know if
> neither are doable and we can work something else out.
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> open-vm-tools-devel mailing list
> open-vm-tools-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
>
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
open-vm-tools-devel mailing list
open-vm-tools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
