> I have tried to fix the problems in this new patch. Thank you for the > review.
Thanks, this looks very good. I appreciate your diligence with our coding standard; it's certainly not easy to pick up a new one. Here is an additional round of comments: - Can GuestApp_ControlRecord return a Bool indicating the success or failure of the operation? That is, can bp.out.ax.halfs.low be interpreted by the function itself as success or failure so that the caller need not? - We should probably require root for these new commands. That involves setting the third argument in the command table (toolbox-cmd.c) to TRUE instead of FALSE for the command line toolbox, and adding a geteuid check in toolboxRecord.c (see toolboxScripts.c or toolboxShrink.c for an example). - The function header for RecordHelp still says "StatHelp" and refers to the stat command. - Since Record_OnStart and Record_OnStop are static functions, they shouldn't have underscores in their names (we use underscore to show that a function is "public" or "exported", depending on the context). - When declaring a pointer type, separate the type and the asterisk with a space. So "GtkWidget*" should be "GtkWidget *" (near Record_Create). - There should be two empty lines separating functions (toolboxRecord.c and toolboxcmdRecord.c). - In Record_StopRecording's function header, "proccess," --> "process.". > The agreement, however, puzzles me a little. Date seems not suitable > for the first blank according to the preceded text, but I can find no > more phrase for that. I think the first and second blanks are for the month+day and year respectively. So if you signed the agreement today, the first line would look like this: This Contributor Agreement (the "Agreement") effective as of August 20th, 2008 by and between... Does that help clarify it? ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ open-vm-tools-devel mailing list open-vm-tools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
