Hi,
More often than not, I find the code enclosed by #ifdef TARG_SL are
in poor shape.
At very least, they look cosmetically sloppy:
- the code are not indented properly. In some cases, previous
statement starts at column n,
and the immediate next statement may start at column n-4!
- lots of commented statement. Some statements are partially
comments, making
code navigating very hard. I still find such cases in the change
you just committed.
e.g.
// for (....) {
you real code
//}
- there are lots of meaningless labels instead of comments.e.g
#ifdef TARG_SL //minor_reg_alloc
Just to name a few
Shuxin
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
