Please do "svn up" in gra_mon directory.
My commit is just for this question.
2010/8/5 shuxin yang <shuxinyang2...@gmail.com>
> I stumble on GRA the other day. Those codes enclosed by #ifdef TARG_SL
> looks
> hideous in vi editor. It seems not very bad in firefox mail client. For 1).
> Here is an example, line 341 and 342 starts at column 6 and 4 respectively.
>
> 337 #ifdef TARG_SL //minor_reg_alloc
> 338 // if( !lrange->Spans_Multiregions()) {
> 339 vector< RID* > rid_vec;
> 340 vector<RID* >::iterator iter;
> 341 Get_Rid_For_Lrange(lrange, &rid_vec);
> 342 for(iter = rid_vec.begin(); iter != rid_vec.end(); iter++) {
> 343 RID* rid = *iter;
> 344 if(rid && RID_TYPE_minor(rid)) {
> 345 RID * pair_rid = gra_para_region_mgr.Get_Pair_Rid(rid);
> 346 Is_True((pair_rid), ("pair_rid is NULL"));
> 347 GRA_PARA_REGION* pair_region =
> gra_para_region_mgr.Get(pair_rid);
> 348 pair_region->Add_One_Exclude_Register(rc, reg);
> 349 }
> 350 }
> 351 // }
> 352 #endif
>
>
>
> ruifen Shen wrote:
>
>> hi, shuxin.
>> Thanks for you review. I have some different proposal for your review
>> comment.
>> - the code are not indented properly. In some cases, previous
>> statement starts at column n,
>> and the immediate next statement may start at column n-4!
>> (1) For this comment. I have double check the GRA code embedded by
>> TARG_SL, I do not found such code in your description.
>> Could you please give me an example?
>> PS: I do not format other code.
>>
>> - lots of commented statement. Some statements are partially
>> comments, making
>> code navigating very hard. I still find such cases in the change
>> you just committed.
>> e.g.
>> // for (....) {
>> you real code
>> //}
>> (2) I think that the comment code may be useful in the future. So I do not
>> cut it.
>> - there are lots of meaningless labels instead of comments.e.g
>> #ifdef TARG_SL //minor_reg_alloc
>>
>> (3) ?? I dont know the meaning of this item. SO sorry.
>>
>>
>>
>
--
Best Regards.
Shen Ruifen
tel: 010-51266989-226
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
