Thank you Jian-Xin for reviewing David's changes to make a build on Ubuntul. I took a quick look at the patch file and the change looks fine. David: please go ahead with your checkin.
- Suneel On Mon, Sep 13, 2010 at 6:22 PM, Jian-Xin Lai <laij...@gmail.com> wrote: > I looked at this patch and I think it's OK. but I'm not the gate keeper for > makefiles. > Can global keepers approve this patch? > > 2010/9/7 David Coakley <dcoak...@gmail.com> >> >> Could a gatekeeper review the attached Makefile patch? >> >> The main purpose of the patch is to make it easier to build on Ubuntu >> systems, where bash is not the default shell. The patch includes >> rewrites of two rules that were using bash-specific operators. After >> this patch, you no longer need to set the SHELL environment variable >> before building on Ubuntu. >> >> Also, the patch changes 'make clean' to be more complete -- it was >> only cleaning half of the libraries on x86-64. >> >> Finally, there is a fix for a build problem with my recent changes to >> the libhugetlbfs Makefile (r3326). Thanks, >> >> -David Coakley / AMD Open Source Compiler Engineering >> >> >> ------------------------------------------------------------------------------ >> This SF.net Dev2Dev email is sponsored by: >> >> Show off your parallel programming skills. >> Enter the Intel(R) Threading Challenge 2010. >> http://p.sf.net/sfu/intel-thread-sfd >> _______________________________________________ >> Open64-devel mailing list >> Open64-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/open64-devel >> > > > > -- > Regards, > Lai Jian-Xin > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
