Thanks, yes, I wrote the code in the diff. -----Original Message----- From: Sun Chan [mailto:sun.c...@gmail.com] Sent: Wednesday, December 01, 2010 11:26 AM To: Ramanarayanan, Ramshankar Cc: open64-devel@lists.sourceforge.net Subject: Re: [Open64-devel] code review request for EXTRACT_BITS simplify routine
ok. The change looks fine. This code is completely written by you? Sun On Wed, Dec 1, 2010 at 1:41 PM, Ramanarayanan, Ramshankar <ramshankar.ramanaraya...@amd.com> wrote: > Yeah, that is how the functionality is for simp_node functions in > osprey/common/com/wn_simp_code.h. We are relying on it returning a NULL > pointer to figure out that a simplification did not happen. The null values > are passed up the call chains to top level simplifier and in this case it is > WN_Simplify_Rebuild_Expr_Tree in osprey/common/com/wn_simp.cxx. Please look > at the calls WN_Simplify_Rebuild_Expr_Tree is making to WN_SimplifyIload, > WN_SimplifyIntrinsic, WN_SimplifyExp1, WN_SimplifyCvtl, WN_SimplifyExp2, > WN_SimplifyExp2. > > -----Original Message----- > From: Sun Chan [mailto:sun.c...@gmail.com] > Sent: Wednesday, December 01, 2010 11:02 AM > To: Ramanarayanan, Ramshankar > Cc: open64-devel@lists.sourceforge.net > Subject: Re: [Open64-devel] code review request for EXTRACT_BITS simplify > routine > > one question, is this ftable thing always return null if not > successful in simplifying? > Sun > > On Wed, Dec 1, 2010 at 12:42 PM, Ramanarayanan, Ramshankar > <ramshankar.ramanaraya...@amd.com> wrote: >> Hi >> >> >> >> I would like a code review for the attached file >> "extract_bits_with_simpnode.diff". This is a fix for a recent regression >> which is seen with virtual destructors. A test case, test_virt_destr.cpp, is >> attached. >> >> >> >> The issue is that we are not removing dead code (and unreachable code) in >> WOPT in case the if-test contains EXTRACT_BITS. I am introducing a simp_node >> function that bypasses EXTRACT_BITS when it is extracting the last bit of a >> Boolean constant. This plugs in to the simp_node framework and further >> simplifications are also possible, in the future. >> >> >> >> The assembly with and without the patch are test_virt_destr_with_fix.s and >> test_virt_destr_with_dead_code.s respectively. Please look at the destructor >> functions: _ZN9TestClassD1Ev, _ZN9TestClassD2Ev for the dead code. >> >> >> >> Please let me know. >> >> >> >> Regards, >> >> Ram >> >> AMD Open Source Compiler Engineering, Bangalore, India >> >> ------------------------------------------------------------------------------ >> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! >> Tap into the largest installed PC base & get more eyes on your game by >> optimizing for Intel(R) Graphics Technology. Get started today with the >> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. >> http://p.sf.net/sfu/intelisp-dev2dev >> _______________________________________________ >> Open64-devel mailing list >> Open64-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/open64-devel >> >> > > > ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
