Could a gatekeeper review this change when they have the chance?
Thanks,
Doug
From: Gilmore, Doug [mailto:doug.gilm...@amd.com]
Sent: Friday, December 03, 2010 1:43 PM
To: open64-devel
Subject: Re: [Open64-devel] review request for a fix to bug 628, backend
assertion with popcount builtin
I updated the patch attached to the bug report to reflect Jian-Xin's commit:
https://bugs.open64.net/show_bug.cgi?id=628
Is it OK if I commit this patch?
Doug
From: Gilmore, Doug [mailto:doug.gilm...@amd.com]
Sent: Friday, December 03, 2010 12:35 PM
To: Jian-Xin Lai
Cc: open64-devel
Subject: Re: [Open64-devel] review request for a fix to bug 628, backend
assertion with popcount builtin
Looks good, thanks!
Doug
From: Jian-Xin Lai [mailto:laij...@gmail.com]
Sent: Friday, December 03, 2010 12:11 PM
To: Gilmore, Doug
Cc: Sun Chan; open64-devel
Subject: Re: [Open64-devel] review request for a fix to bug 628, backend
assertion with popcount builtin
I will copy the license from the original file like this:
/*
* Copyright (C) 2007. QLogic Corporation. All Rights Reserved.
*/
/*
* Copyright 2003, 2004, 2005, 2006 PathScale, Inc. All Rights Reserved.
*/
/*
Copyright (C) 2000, 2001 Silicon Graphics, Inc. All Rights Reserved.
This program is free software; you can redistribute it and/or modify it
under the terms of version 2 of the GNU General Public License as
published by the Free Software Foundation.
This program is distributed in the hope that it would be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Further, this software is distributed without any warranty that it is
free of the rightful claim of any third person regarding infringement
or the like. Any license provided herein, whether implied or
otherwise, applies only to this software file. Patent licenses, if
any, provided herein do not apply to combinations of this program with
other software, or any other product whatsoever.
You should have received a copy of the GNU General Public License along
with this program; if not, write the Free Software Foundation, Inc., 59
Temple Place - Suite 330, Boston MA 02111-1307, USA.
Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pky,
Mountain View, CA 94043, or:
http://www.sgi.com
For further information regarding this notice, see:
http://oss.sgi.com/projects/GenInfo/NoticeExplan
*/
Is it OK? Thank you very much.
2010/12/3 Jian-Xin Lai <laij...@gmail.com<mailto:laij...@gmail.com>>
That file is introduced by me and it's derived from another SGI source file.
But at that time I don't pay attention to the license issue. I will submit a
patch to switch the license back to GPLv2.
2010/12/2 Gilmore, Doug <doug.gilm...@amd.com<mailto:doug.gilm...@amd.com>>
The old license on intrn_entry.def was BSD, which with my patch is
would be changed to GPLv2. Both are compatible with Open64.
My point of the change is that intrn_entry.def could be considered to
be a derived work, and if so, the copyright notices and license should
reflect that of the previous work. Note the license on the previous
work was GPLv2.
I don't think there are any licensing issues with the patch that
implements the fix. The issue is whether intrn_entry.def is a derived
work or not. If people are comfortable in saying that it was not a
derived work, which gave us the freedom at the time of commit r1764 to
set the license on to intrn_entry.def to BSD, then no change of
license is needed.
I attached the patch associated with commit r1764. Keep in mind
that the patch is against the tree branches/merge08, where
the PSC 3.2 (and others) merge was done.
I added another patch to the bug report with no license change, but
I did add a copyright notice for the change that I just added.
If people think that my interpretation of copyright law is too
strict then we can go ahead and apply that patch instead.
Doug
> -----Original Message-----
> From: Sun Chan [mailto:sun.c...@gmail.com<mailto:sun.c...@gmail.com>]
> Sent: Thursday, December 02, 2010 4:46 PM
> To: Gilmore, Doug
> Cc: open64-devel
> Subject: Re: [Open64-devel] review request for a fix to bug 628,
> backend assertion with popcount builtin
>
> I suggest someone check the license compatibility (or whatever) before
> the checkin. This is likely beyond gatekeeper capability
> Sun
>
> On Fri, Dec 3, 2010 at 8:41 AM, Gilmore, Doug
> <doug.gilm...@amd.com<mailto:doug.gilm...@amd.com>>
> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Sun Chan [mailto:sun.c...@gmail.com<mailto:sun.c...@gmail.com>]
> >> Sent: Thursday, December 02, 2010 4:22 PM
> >> To: Gilmore, Doug
> >> Cc: open64-devel
> >> Subject: Re: [Open64-devel] review request for a fix to bug 628,
> >> backend assertion with popcount builtin
> >>
> >> This fix would have been in the merge I coordinated but never
> "checked
> >> in".
> > Right.
> >> I assume there is no copy right issues since it is before the
> >> change to gpl3.0
> >> Sun
> > Per the last comment that I added to the bug, what is unusual with
> this patch
> > is that license on one of the files was changed from BSD to GPLv2,
> since
> > it is safer to consider this file addition as a derived work.
> >
> > Doug
> >>
> >> On Fri, Dec 3, 2010 at 8:17 AM, Gilmore, Doug
> >> <doug.gilm...@amd.com<mailto:doug.gilm...@amd.com>>
> >> wrote:
> >> > Again, the bug fix is attached to the patch.
> >> >
> >> > https://bugs.open64.net/show_bug.cgi?id=628
> >> >
> >> > Could someone take a look at this when they have the chance?
> >> >
> >> > Thanks,
> >> >
> >> > Doug
> >> >
> >> >
> >> >
> >> > ------------------------------------------------------------------
> ---
> >> ---------
> >> > Increase Visibility of Your 3D Game App & Earn a Chance To Win
> $500!
> >> > Tap into the largest installed PC base & get more eyes on your
> game
> >> by
> >> > optimizing for Intel(R) Graphics Technology. Get started today
> with
> >> the
> >> > Intel(R) Software Partner Program. Five $500 cash prizes are up
> for
> >> grabs.
> >> > http://p.sf.net/sfu/intelisp-dev2dev
> >> > _______________________________________________
> >> > Open64-devel mailing list
> >> > Open64-devel@lists.sourceforge.net<mailto:Open64-devel@lists.sourceforge.net>
> >> > https://lists.sourceforge.net/lists/listinfo/open64-devel
> >> >
> >
> >
> >
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net<mailto:Open64-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/open64-devel
--
Regards,
Lai Jian-Xin
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
This SF Dev2Dev email is sponsored by:
WikiLeaks The End of the Free Internet
http://p.sf.net/sfu/therealnews-com
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
