Hi Gang, I looked at the build_system, driver, and isa_subset_sl patches. Here are my comments:
1. In the new file INSTALL.cross.sl, please use the current license template instead of the old SGI license. Here is the the link to the template: http://wiki.open64.net/index.php/LicenseTemplate 2. In configure.ac, this SL-specific code looks strange. Is that ':' supposed to be there? if test "${BUILD_TARGET}" = "SL"; then AC_CONFIG_FILES([ osprey/targdir_lib/libinstr/Makefile:osprey/targdir_lib/libinstr2/Makefile.in ]) 3. Can you explain the issue with -fcxx-openmp? I do not understand why you needed to add the ifdef's in the driver. Thanks, -David Coakley / AMD Open Source Compiler Engineering On Fri, Apr 1, 2011 at 10:56 PM, Gang Yu <yugang...@gmail.com> wrote: > Hi ,all : > > SL is ready to merge SL changes to trunk. We have divided the them > into the > following cases. Can gatekeepers help review our changes? > > About this SL merge, > > 1). all changed code goes under #TARG_SL. except gcm.cxx, where we > rearranged some code for readability, but no logic change. > > 2). SL target adds the installaion scripts now, so one can compile and > install the SL compiler and do compile programs. > > 3).support ISA subset, we updated our SI code for David Coakley's static > scheduler patch. > The regression and tests show it is ok. > > 4). According to Fred's comments and Lai Jianxin's patch, we cleaned up > the I2I2ILOAD code in opt. > 5). For the opt_cfg.cxx > @@ -1273,6 +1270,9 @@ > // mpy is usually fast on nvisa > opr == OPR_MPY || > #endif > +#ifdef TARG_SL > + opr == OPR_MIN || opr == OPR_MAX || > +#endif > this TARG_SL can be removed (we have not done thoroughly tests, so we > left the #ifdef). since change for MIN and MAX operators for SELECT can get > better nested condition > move, here is an example > int a,b,c,d; > int foo(void) > { > return ( a == b )? (c<d?c:d) : 0; > } > > Any questions please let us know. > > Thanks > Gang > > ------------------------------------------------------------------------------ > Create and publish websites with WebMatrix > Use the most popular FREE web apps or write code yourself; > WebMatrix provides all the features you need to develop and > publish your website. http://p.sf.net/sfu/ms-webmatrix-sf > > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ Xperia(TM) PLAY It's a major breakthrough. An authentic gaming smartphone on the nation's most reliable network. And it wants your games. http://p.sf.net/sfu/verizon-sfdev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
