Hi Gang, I don't think you need the old SGI license text in the new source file. You can just include what is in the current license template.
Otherwise, these parts of the SL merge look ok to check in. -David Coakley / AMD Open Source Compiler Engineering On Thu, Apr 7, 2011 at 12:56 AM, Gang Yu <yugang...@gmail.com> wrote: > Hi David, > > Thank you very much. > > On Thu, Apr 7, 2011 at 1:09 PM, David Coakley <dcoak...@gmail.com> wrote: >> >> Hi Gang, >> >> I looked at the build_system, driver, and isa_subset_sl patches. Here >> are my comments: >> >> 1. In the new file INSTALL.cross.sl, please use the current license >> template instead of the old SGI license. Here is the the link to the >> template: >> >> http://wiki.open64.net/index.php/LicenseTemplate > > Yes, I have an update. Please check the attach. > >> >> 2. In configure.ac, this SL-specific code looks strange. Is that ':' >> supposed to be there? >> >> if test "${BUILD_TARGET}" = "SL"; then >> AC_CONFIG_FILES([ >> >> osprey/targdir_lib/libinstr/Makefile:osprey/targdir_lib/libinstr2/Makefile.in >> ]) > > Yes, it is intended. We changed to the new libinstr when the build system > was updated. > >> >> 3. Can you explain the issue with -fcxx-openmp? I do not understand >> why you needed to add the ifdef's in the driver. Thanks, >> > > SL is an embedded system company rather than HPC one, openmp is undisired > and we don't want to be bothered by it. So the SL driver cleans the flag. > >> -David Coakley / AMD Open Source Compiler Engineering >> > > ------------------------------------------------------------------------------ Xperia(TM) PLAY It's a major breakthrough. An authentic gaming smartphone on the nation's most reliable network. And it wants your games. http://p.sf.net/sfu/verizon-sfdev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
