Thx!
Your change is fine. Please go ahead
Sun
On Thu, Apr 14, 2011 at 2:33 PM, Yiran Wang <yiran.w...@gmail.com> wrote:
> The SGI document on WHIRL also mentioned this OPR.
> yiran
>
> On Thu, Apr 14, 2011 at 2:31 PM, Yiran Wang <yiran.w...@gmail.com> wrote:
>>
>> I do not know. But, it seems like the operator is not new at all, but
>> somebody (probably PathScale?) use it in some different way here.
>> OPR_NEG = 87,
>> OPR_NMADD = 88,
>> OPR_NMSUB = 89,
>> OPR_OPTPARM = 90,
>> OPR_OPT_CHI = 91,
>> OPR_OPT_RESERVE2 = 92,
>> OPR_PAREN = 93,
>> OPR_PARM = 94,
>> OPR_PICCALL = 95,
>> OPR_PRAGMA = 96,
>> OPR_PREFETCH = 97,
>> OPR_PREFETCHX = 98,
>> OPR_RCOMMA = 99,
>> OPR_FIRSTPART = 100,
>> OPR_RECIP = 101,
>> OPR_REGION = 102,
>> OPR_REGION_EXIT = 103,
>> OPR_REM = 104,
>> OPR_RETURN = 105,
>> OPR_RETURN_VAL = 106,
>> OPR_RND = 107,
>> OPR_RSQRT = 108,
>> OPR_SELECT = 109,
>> OPR_SHL = 110,
>> OPR_SQRT = 111,
>> OPR_STBITS = 112,
>>
>> The above is a fragment from opcode_gen_core.h.
>> Best Regards,
>> yiran
>> On Thu, Apr 14, 2011 at 2:23 PM, Sun Chan <sun.c...@gmail.com> wrote:
>> > my question is, who added this operator? This is a change in WHIRL
>> > Sun
>> >
>> > On Thu, Apr 14, 2011 at 2:20 PM, Yiran Wang <yiran.w...@gmail.com>
>> > wrote:
>> >> The function is Simd_Mark_Code (WN* wn) . It is called by
>> >> Mark_Auto_Vectorizable_Loops in the LNO driver.
>> >>
>> >> The following is some comments there.
>> >>
>> >> /* To facilitate vectorization, convert all
>> >> * ISTORE of CONST/LDID/ILOAD into ISTORE of PAREN of CONST/LDID/ILOAD
>> >> * PAREN nodes are later converted into NOPs. So, there are no new
>> >> * instructions generated, but vectorizer can assume PAREN is a
>> >> * vectorizable op and proceed. */
>> >> static void Simd_Mark_Code (WN* wn)
>> >>
>> >>
>> >> Best Regards,
>> >> yiran
>> >>
>> >> On Thu, Apr 14, 2011 at 2:12 PM, Sun Chan <sun.c...@gmail.com> wrote:
>> >>> who added this?
>> >>> Sun
>> >>>
>> >>> On Thu, Apr 14, 2011 at 1:19 PM, Yiran Wang <yiran.w...@gmail.com>
>> >>> wrote:
>> >>>> basically, it is just a dummy, the tree rooted here has the same
>> >>>> meaning of its only child. Literally, it is a parenthesis.
>> >>>>
>> >>>> SIMD phase add such nodes to facilitate itself in someway.
>> >>>>
>> >>>> Best Regards,
>> >>>> yiran
>> >>>>
>> >>>>
>> >>>> On Wed, Apr 13, 2011 at 5:13 PM, Sun Chan <sun.c...@gmail.com> wrote:
>> >>>>> sorry, what does this OPR_PAREN opcode mean?
>> >>>>> Sun
>> >>>>>
>> >>>>> On Wed, Apr 13, 2011 at 11:13 AM, Yiran Wang <yiran.w...@gmail.com>
>> >>>>> wrote:
>> >>>>>> Hi,
>> >>>>>> could a gatekeeper please review this patch?
>> >>>>>>
>> >>>>>> This change is to deal with the OPR_PAREN nodes in this subroutine,
>> >>>>>> which is inserted by simd-mark-code phase.
>> >>>>>>
>> >>>>>> Best Regards,
>> >>>>>> yiran
>> >>>>>>
>> >>>>>> Index: osprey/be/lno/scalar_expand.cxx
>> >>>>>> ===================================================================
>> >>>>>> --- osprey/be/lno/scalar_expand.cxx (revision 1350)
>> >>>>>> +++ osprey/be/lno/scalar_expand.cxx (revision 1351)
>> >>>>>> @@ -920,6 +920,8 @@
>> >>>>>> OPCODE wn_op = WN_opcode(wn);
>> >>>>>> OPERATOR wn_oper = OPCODE_operator(wn_op);
>> >>>>>> switch (wn_oper) {
>> >>>>>> + case OPR_PAREN:
>> >>>>>> + return BND_Min_Expr(WN_kid0(wn), loops, nloops);
>> >>>>>> case OPR_INTCONST:
>> >>>>>> return LWN_Copy_Tree(wn, TRUE, LNO_Info_Map);
>> >>>>>> case OPR_LDID:
>> >>>>>> @@ -1047,6 +1049,8 @@
>> >>>>>> WN* wn_new = NULL;
>> >>>>>>
>> >>>>>> switch (wn_oper) {
>> >>>>>> + case OPR_PAREN:
>> >>>>>> + return BND_Max_Expr(WN_kid0(wn), loops, nloops);
>> >>>>>> case OPR_INTCONST:
>> >>>>>> return LWN_Copy_Tree(wn, TRUE, LNO_Info_Map);
>> >>>>>> case OPR_LDID:
>> >>>>>>
>> >>>>>>
>> >>>>>> ------------------------------------------------------------------------------
>> >>>>>> Forrester Wave Report - Recovery time is now measured in hours and
>> >>>>>> minutes
>> >>>>>> not days. Key insights are discussed in the 2010 Forrester Wave
>> >>>>>> Report as
>> >>>>>> part of an in-depth evaluation of disaster recovery service
>> >>>>>> providers.
>> >>>>>> Forrester found the best-in-class provider in terms of services and
>> >>>>>> vision.
>> >>>>>> Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
>> >>>>>> _______________________________________________
>> >>>>>> Open64-devel mailing list
>> >>>>>> Open64-devel@lists.sourceforge.net
>> >>>>>> https://lists.sourceforge.net/lists/listinfo/open64-devel
>> >>>>>>
>> >>>>>
>> >>>>
>> >>>
>> >>
>> >
>>
>
>
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
