looking at the diff, I don't fully understand this "outof memory" issue. Can you clarify? Sun
On Thu, Jul 7, 2011 at 5:15 AM, Ye, Mei <mei...@amd.com> wrote: > Even if control flow optimization does not happen in preopt now, it can > happen in the future. > It is likely that the "out of memory" issue is a bug in the design or > implementation of adding an EH exit block which is not exposed by the mainopt. > So I don't quite agree on this fix. Let's hear from other gatekeeper's > opinion. > > -Mei > > -----Original Message----- > From: David Coakley [mailto:dcoak...@gmail.com] > Sent: Wednesday, July 06, 2011 1:52 PM > To: open64-devel > Subject: [Open64-devel] Code review request: add region exit blocks only when > needed [OPT] > > Could a gatekeeper review the attached patch to files > osprey/be/opt/opt_main.cxx and opt_cfg.[cxx,h]? Here is the > description: > > When we enhanced the control flow optimization to handle the PU with EH > regions in the previous release, we added a region exit block for each EH > region during the CFG construction. These extra blocks are unnecessary when > CFG is built but no control flow optimization is performed. Indeed, control > flow optimization only happens in mainopt. > These unnecessary extra blocks may cause "out of memory" issue in preopt. > Thus, this change is to add these region exit blocks only when CFG control > flow optimization is performed (i.e. mainopt). > > Thanks, > > -David Coakley / AMD Open Source Compiler Engineering > > > ------------------------------------------------------------------------------ > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
