Hi Yongchong, I looked at your fix for ia64. A couple of comments: 1) For the first part of the fix, is I4NEG the only place that could have problem? How about other I4XXX, like I4ABS?
2) For the second part of the fix, I think your first version is good enough. Why we need to have special handling for I1/I2/I4? Does sign extension already happen (since we are using TCON_I8)? Since this change will impact other targets, would someone please review for other targets? Thanks, Min On Tue, Aug 16, 2011 at 2:22 AM, Wu Yongchong <wuyongch...@gmail.com> wrote: > Here is an improved version that deal with the situation of MTYPE_I1, > MTYPE_I2 and MTYPE_I4 > > On Sun, Aug 14, 2011 at 1:07 PM, Wu Yongchong <wuyongch...@gmail.com> wrote: >> Hi, >> >> Can a gatekeeper help review this patch. the patch fixed bug 855, >> >> https://bugs.open64.net/show_bug.cgi?id=855 >> >> This patch will be change the file targ_const.cxx in all 7 target, >> ia64, x8664, MIPS, NVISA, ppc32, loongson and SL . >> >> The first hunk of the patch make sure after simplify I4NEG, if the >> TCON is negative of machine type MTYPE_I4, TCON_v1() is -1. It fixed >> the assertion failure error in >> osprey/common/com/ia64/targ_const.cxx:232 >> >> The second hunk of the patch make sure TCON_v1() of machine MTYPE_U1, >> MTYPE_U2 and MTYPE_U4 is 0. It fixed the assertion failure error in >> osprey/common/com/ia64/targ_const.cxx:242 >> >> -- >> yongchong >> > > > > -- > yongchong > > ------------------------------------------------------------------------------ > uberSVN's rich system and user administration capabilities and model > configuration take the hassle out of deploying and managing Subversion and > the tools developers use with it. Learn more about uberSVN and get a free > download at: http://p.sf.net/sfu/wandisco-dev2dev > > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
