Hi Yong-Chong, I'm OK with your fix. It's better if you could get review from SL (or others).
Thanks, Min On Tue, Aug 23, 2011 at 2:02 AM, Wu Yongchong <wuyongch...@gmail.com> wrote: > Hi, Min > 1), yes, not only I4NEG, but also I4ABS, I4ADD... has the same > problem. I have modify this part, add the following code outside the > switch clause. > if(TCON_ty(c0) == MTYPE_I4) > TCON_v1(c0)=(TCON_I4(c0)<0)?-1:0; > 2). I1/I2/I4 should be handling because if I8 is a large positive > number like 0x0000000100000001, than TCON_v1 is 1, but TCON_v1 should > be either -1 or 0. > > Here is the new patch > > On Fri, Aug 19, 2011 at 3:37 AM, Min Zhao <mzhao...@gmail.com> wrote: >> Hi Yongchong, >> >> I looked at your fix for ia64. A couple of comments: >> 1) For the first part of the fix, is I4NEG the only place that could >> have problem? How about other I4XXX, like I4ABS? >> >> 2) For the second part of the fix, I think your first version is good >> enough. Why we need to have special handling for I1/I2/I4? Does sign >> extension already happen (since we are using TCON_I8)? >> >> Since this change will impact other targets, would someone please >> review for other targets? >> >> Thanks, >> >> Min >> >> On Tue, Aug 16, 2011 at 2:22 AM, Wu Yongchong <wuyongch...@gmail.com> wrote: >>> Here is an improved version that deal with the situation of MTYPE_I1, >>> MTYPE_I2 and MTYPE_I4 >>> >>> On Sun, Aug 14, 2011 at 1:07 PM, Wu Yongchong <wuyongch...@gmail.com> wrote: >>>> Hi, >>>> >>>> Can a gatekeeper help review this patch. the patch fixed bug 855, >>>> >>>> https://bugs.open64.net/show_bug.cgi?id=855 >>>> >>>> This patch will be change the file targ_const.cxx in all 7 target, >>>> ia64, x8664, MIPS, NVISA, ppc32, loongson and SL . >>>> >>>> The first hunk of the patch make sure after simplify I4NEG, if the >>>> TCON is negative of machine type MTYPE_I4, TCON_v1() is -1. It fixed >>>> the assertion failure error in >>>> osprey/common/com/ia64/targ_const.cxx:232 >>>> >>>> The second hunk of the patch make sure TCON_v1() of machine MTYPE_U1, >>>> MTYPE_U2 and MTYPE_U4 is 0. It fixed the assertion failure error in >>>> osprey/common/com/ia64/targ_const.cxx:242 >>>> >>>> -- >>>> yongchong >>>> >>> >>> >>> >>> -- >>> yongchong >>> >>> ------------------------------------------------------------------------------ >>> uberSVN's rich system and user administration capabilities and model >>> configuration take the hassle out of deploying and managing Subversion and >>> the tools developers use with it. Learn more about uberSVN and get a free >>> download at: http://p.sf.net/sfu/wandisco-dev2dev >>> >>> _______________________________________________ >>> Open64-devel mailing list >>> Open64-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/open64-devel >>> >>> >> > > > > -- > yongchong > ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
