Hi Gang,
Sorry for the delay. I have the following comments on this patch:
1. osprey/be/cg/cgemit.cxx, changes about "Emit_Phase_Validity_Check", I
prefer to declare this in cgemit.h and provide fake implementation for all
other platform. FmtAssert FALSE can be used in the fake implementation. The
same problem about "Target_Specific_ZDLBR_Expansion" in
osprey/be/cg/whirl2ops.cxx. The major reason is "attribute weak" is not very
portable.
2. About TOP_auxbr, is it possible to remove it from the OP_branch or
OP_cond group in SL's targinfo? So that you don't need to add special code
to check that TOP.
3. In osprey/common/com/opcode_gen_core.h, since OPR_ZDLBR is added for all
targets, why not move it out of the #ifdef and change the value for the
later OPRs?
4. In osprey/common/com/SL/targ_const.cxx, I think Yong-Chong has fixed this
assertion, the change should be removed from the patch.
5. In osprey/common/com/SL/config_targ.h, why not define this macro in the
makefile for SL?
6. It looks like there is no options to skip some of the ZDL transformation?
is it only controlled by the pragma?
7. There are some format issues, especially about the space, tab stop,
coding style, etc.
For example, line 224, 271, 406, 425, 446~448, 1602, 2265, 2514, 2526, 2582
etc
2011/8/8 Gang Yu <yugang...@gmail.com>
> Hi,
>
> We plan to merge the ZDL feature into the trunk, Below is an abstraction
> to this check-in.
>
> we have a new design and implementation for the open64's support for DSP
> Zero-Delay-Loop(ZDL) feature. This ZDL contribution is a co-operational
> approach of global scalar optimizer WOPT and the Code Generation component
> CG. We implement the common ZDL features, i.e, the loop counting mechanism
> hidden and bottom loop condition abstracted in WOPT. The changes in WOPT are
> minimized while keeping the maximum optimizing result. We also introduce a
> pseudo branch op method to expand ZDL WHIRL operator and delay the ZDL
> hardware instruction generation to the very last phase of CG loop
> optimization. This lazy implementation helps keeping the compatibility with
> other CG loop optimizations to produce the most optimal code. We believe
> with the new ZDL implementation, open64 provides the equal expressibility to
> gcc's doloop_begin, doloop_end and decrement_and_branch_until_zero patterns.
>
> Attached please find the detail notes for ZDL feature.
> a.) a brief introduction to ZDL.
> b.) a concept description to the newly added WHIRL operator OPR_ZDLBR.
> c.) the formal definition for OPR_ZDLBR.
> d.) the design and implementation ideas for the ZDL approach.
> e.) evaluation on the mainly code changes to current svn trunk.
> f.) porting guide for other ZDL targets.
> g.) discussions on tests and issues.
>
> Please gatekeeper help a review.
>
> Thanks
> Gang
>
>
> ------------------------------------------------------------------------------
> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
