Mei, I read through your changes, and did not see any blocking issues.
However, here are some minor comments from Sun Chan and me, for your future
consideration:
1. You may want to add more assertions.
2. I see that you already did some minor reorganization of your code; in
the future you may want to do more reorganization with respect to what should
be in WOPT and what can be moved out of WOPT.
3. There are some obsolete #ifdef's that can be removed (in wn.cxx).
Thanks,
Michael Lai
From: Ye, Mei [mailto:mei...@amd.com]
Sent: Thursday, January 26, 2012 3:33 PM
To: 'open64-devel@lists.sourceforge.net'
Subject: [Open64-devel] code review (WOPT)
Attached patch is an enhancement of proactive loop opt. It allows tail
duplication of SC_Ifs to enable more if-merging., and allows
extended-proactive-loop-opt phase to remove more redundant bit-operations and
empty if-regions. Also does some minor reorg for code sharing.
-Mei
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
